On 26/08/2024 09:46, Junhao Xie wrote: > On 2024/8/26 14:06, Krzysztof Kozlowski wrote: >> On Mon, Aug 26, 2024 at 12:44:13PM +0800, Junhao Xie wrote: >>> Add dts for LCKFB Taishan Pi. >>> > > [...] > >> >>> + dc_12v: dc-12v { >> >> Use some reasonable prefix or suffix (regulator) for all regulator >> nodes. Or even: use name for all fixed regulators which matches current >> format recommendation: 'regulator-[0-9]v[0-9]' >> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml?h=v6.11-rc1#n46 >> > > Thanks, I will rename it to dc-12v-regulator Well, this makes ordering tricky and is not the proposed policy, but sure... I gave you reference hoping you will read it. Best regards, Krzysztof