On 2024/8/26 14:06, Krzysztof Kozlowski wrote:
> On Mon, Aug 26, 2024 at 12:44:13PM +0800, Junhao Xie wrote:
>> Add dts for LCKFB Taishan Pi.
>>
[...]
>
>> + dc_12v: dc-12v {
>
> Use some reasonable prefix or suffix (regulator) for all regulator
> nodes. Or even: use name for all fixed regulators which matches current
> format recommendation: 'regulator-[0-9]v[0-9]'
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml?h=v6.11-rc1#n46
>
Thanks, I will rename it to dc-12v-regulator
[...]
>> +
>> +&sdhci {
>> + bus-width = <8>;
>> + max-frequency = <200000000>;
>> + non-removable;
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&emmc_bus8 &emmc_clk &emmc_cmd &emmc_datastrobe &emmc_rstnout>;
>> + status = "okay";
>
> Keep status the last.
>
> Best regards,
> Krzysztof
>
>
Thanks for your review, I will fix all problems and post patch v2!
