Hi Daniel, kernel test robot noticed the following build warnings: [auto build test WARNING on net-next/main] url: https://github.com/intel-lab-lkp/linux/commits/Daniel-Golle/net-phy-aquantia-allow-forcing-order-of-MDI-pairs/20240821-210717 base: net-next/main patch link: https://lore.kernel.org/r/ed46220cc4c52d630fc481c8148fc749242c368d.1724244281.git.daniel%40makrotopia.org patch subject: [PATCH net-next 2/2] net: phy: aquantia: allow forcing order of MDI pairs config: x86_64-randconfig-123-20240822 (https://download.01.org/0day-ci/archive/20240822/202408221406.WtGcNGxX-lkp@xxxxxxxxx/config) compiler: clang version 18.1.5 (https://github.com/llvm/llvm-project 617a15a9eac96088ae5e9134248d8236e34b91b1) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240822/202408221406.WtGcNGxX-lkp@xxxxxxxxx/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Closes: https://lore.kernel.org/oe-kbuild-all/202408221406.WtGcNGxX-lkp@xxxxxxxxx/ sparse warnings: (new ones prefixed by >>) >> drivers/net/phy/aquantia/aquantia_main.c:483:5: sparse: sparse: symbol 'aqr107_config_mdi' was not declared. Should it be static? drivers/net/phy/aquantia/aquantia_main.c: note: in included file (through include/linux/mmzone.h, include/linux/gfp.h, include/linux/umh.h, include/linux/kmod.h, ...): include/linux/page-flags.h:235:46: sparse: sparse: self-comparison always evaluates to false include/linux/page-flags.h:235:46: sparse: sparse: self-comparison always evaluates to false vim +/aqr107_config_mdi +483 drivers/net/phy/aquantia/aquantia_main.c 482 > 483 int aqr107_config_mdi(struct phy_device *phydev) 484 { 485 struct device_node *np = phydev->mdio.dev.of_node; 486 bool force_normal, force_reverse; 487 488 force_normal = of_property_read_bool(np, "marvell,force-mdi-order-normal"); 489 force_reverse = of_property_read_bool(np, "marvell,force-mdi-order-reverse"); 490 491 if (force_normal && force_reverse) 492 return -EINVAL; 493 494 if (force_normal) 495 return phy_modify_mmd(phydev, MDIO_MMD_PMAPMD, PMAPMD_RSVD_VEND_PROV, 496 PMAPMD_RSVD_VEND_PROV_MDI_CONF, 497 PMAPMD_RSVD_VEND_PROV_MDI_FORCE); 498 499 if (force_reverse) 500 return phy_modify_mmd(phydev, MDIO_MMD_PMAPMD, PMAPMD_RSVD_VEND_PROV, 501 PMAPMD_RSVD_VEND_PROV_MDI_CONF, 502 PMAPMD_RSVD_VEND_PROV_MDI_REVERSE | 503 PMAPMD_RSVD_VEND_PROV_MDI_FORCE); 504 505 return 0; 506 } 507 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
