Re: [PATCH v2 1/3] dt-bindings: display: mediatek: dpi: Add power domains

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 21/08/24 2:59 PM, Krzysztof Kozlowski wrote:
On 21/08/2024 11:26, Rohit Agarwal wrote:
Add power domain binding to the mediatek DPI controller
for MT8186.
Also, add power domain binding for other SoCs like
MT6795 and MT8173 that already had power domain property.

Signed-off-by: Rohit Agarwal <rohiagar@xxxxxxxxxxxx>
---
  .../display/mediatek/mediatek,dpi.yaml        | 19 +++++++++++++++++++
  1 file changed, 19 insertions(+)

diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml
index 5ca7679d5427..864b781fdcea 100644
--- a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml
+++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml
@@ -62,6 +62,8 @@ properties:
        - const: default
        - const: sleep
+ power-domains: true
Missing maxItems. I don't get why did you change this...

+
    port:
      $ref: /schemas/graph.yaml#/properties/port
      description:
@@ -76,6 +78,23 @@ required:
    - clock-names
    - port
+allOf:
+  - if:
+      properties:
+        compatible:
+          contains:
+            enum:
+              - mediatek,mt6795-dpi
+              - mediatek,mt8173-dpi
+              - mediatek,mt8186-dpi
+    then:
+      properties:
+        power-domains:
+          maxItems: 1
This part can be dropped. Just disallow it for other devices.
I was a bit confused here.

Can we add something like this?
if:
  not:
       (mt6795, mt8173, mt8186)
then:
    properties:
        power-domains: false

Thanks,
Rohit.

Best regards,
Krzysztof





[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux