On 21/08/2024 11:26, Rohit Agarwal wrote: > Add power domain binding to the mediatek DPI controller > for MT8186. > Also, add power domain binding for other SoCs like > MT6795 and MT8173 that already had power domain property. > > Signed-off-by: Rohit Agarwal <rohiagar@xxxxxxxxxxxx> > --- > .../display/mediatek/mediatek,dpi.yaml | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml > index 5ca7679d5427..864b781fdcea 100644 > --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml > +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml > @@ -62,6 +62,8 @@ properties: > - const: default > - const: sleep > > + power-domains: true Missing maxItems. I don't get why did you change this... > + > port: > $ref: /schemas/graph.yaml#/properties/port > description: > @@ -76,6 +78,23 @@ required: > - clock-names > - port > > +allOf: > + - if: > + properties: > + compatible: > + contains: > + enum: > + - mediatek,mt6795-dpi > + - mediatek,mt8173-dpi > + - mediatek,mt8186-dpi > + then: > + properties: > + power-domains: > + maxItems: 1 This part can be dropped. Just disallow it for other devices. Best regards, Krzysztof