On 21/08/2024 08:47, Zhao Qunqin wrote: > From: zhaoqunqin <zhaoqunqin@xxxxxxxxxxx> > > Add: drivers/edac/loongson_edac.c > > Signed-off-by: zhaoqunqin <zhaoqunqin@xxxxxxxxxxx> Please use full name, not login. > --- > .../bindings/edac/loongson,ls-mc-edac.yaml | 35 +++++++++++++++++++ Bindings are before users. > MAINTAINERS | 7 ++++ > 2 files changed, 42 insertions(+) > create mode 100644 Documentation/devicetree/bindings/edac/loongson,ls-mc-edac.yaml > > diff --git a/Documentation/devicetree/bindings/edac/loongson,ls-mc-edac.yaml b/Documentation/devicetree/bindings/edac/loongson,ls-mc-edac.yaml > new file mode 100644 > index 000000000..29e5b8381 > --- /dev/null > +++ b/Documentation/devicetree/bindings/edac/loongson,ls-mc-edac.yaml > @@ -0,0 +1,35 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/edac/loongson,ls-mc-edac.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Loongson Memory Controller EDAC > + > +maintainers: > + - Zhao Qunqin <zhaoqunqin@xxxxxxxxxxx> > + > +description: | > + EDAC node is defined to describe on-chip error detection and correction for > + Loongson Memory Controller. > + > +properties: > + > + compatible: > + const: loongson,ls-mc-edac Missing soc part. And then adjust filename to match proper (new) compatible. > + > + reg: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + edac: mc0@1fe00600 { memory-controller@ and drop unused label. > + compatible = "loongson,ls-mc-edac"; > + reg = <0x0 0x1fe00600 0x0 0x50>; > + }; Best regards, Krzysztof