> -----Original Message----- > From: Andrew Lunn <andrew@xxxxxxx> > Sent: 2024年8月20日 21:25 > To: Wei Fang <wei.fang@xxxxxxx> > Cc: davem@xxxxxxxxxxxxx; edumazet@xxxxxxxxxx; kuba@xxxxxxxxxx; > pabeni@xxxxxxxxxx; robh@xxxxxxxxxx; krzk+dt@xxxxxxxxxx; > conor+dt@xxxxxxxxxx; f.fainelli@xxxxxxxxx; hkallweit1@xxxxxxxxx; > linux@xxxxxxxxxxxxxxx; Andrei Botila (OSS) <andrei.botila@xxxxxxxxxxx>; > netdev@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; > linux-kernel@xxxxxxxxxxxxxxx > Subject: Re: [PATCH net-next 1/3] dt-bindings: net: tja11xx: use reverse-mode > to instead of rmii-refclk-in > > > > Sorry, I didn't find the correct PHY driver, could you point me to which PHY > > > driver that I can refer to? > > > The PHY drivers I searched for using the "clk" keyword all seem to set the > > > clock via a vendor defined property. Such as, > > > realtek: "realtek,clkout-disable" > > > dp83867 and dp83869: "ti,clk-output-sel" and > > > "ti,sgmii-ref-clock-output-enable" > > > motorcomm: " motorcomm,tx-clk-1000-inverted" > > > micrel: "rmii-ref" > > > > Hi Andrew, > > I still cannot find a generic method in other PHY drivers to provide > > reference clock by PHY. So I think this patch is the best I could do, at > > least it's more reasonable than the "nxp,rmii-refclk-in" property. > > I did not say there was a generic method. I just said copy one. We > have too many different ways of doing the same thing, so we should not > add another one. Which of these is closest to what you want? You > should use your own vendor part, but copy clk-output-sel, rmii-ref, > etc, and implement the same behaviour in your driver. > Sorry, I misunderstood your meaning. So "reverse-mode" does not seem to be easy to understand its real purpose. Referring to the "adi,phy-output-reference-clock" property, for TJA11xx PHY, we can use the "nxp,phy-output-refclk" to make the PHY provide reference clock.
