Re: [PATCH net-next v6 09/14] net: ethernet: oa_tc6: implement transmit path to transfer tx ethernet frames

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 12 Aug 2024 15:56:06 +0530 Parthiban Veerasooran wrote:
> +		if (skb_queue_len(&tc6->tx_skb_q) < OA_TC6_TX_SKB_QUEUE_SIZE &&
> +		    netif_queue_stopped(tc6->netdev))
> +			netif_wake_queue(tc6->netdev);

FWIW I'm not sure you actually need a queue in the driver.
"A queue of 1" may be enough, IIUC calling netif_wake_queue()
will cause something like an interrupt to fire immediately,
and start_xmit for the next frame should get called before
netif_wake_queue() returns. I could be wrong :)




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux