Hi Conor, On Thu, Aug 15, 2024 at 03:46:18PM +0100, Conor Dooley wrote: > On Thu, Aug 15, 2024 at 12:01:36PM +0200, Stanislav Jakubek wrote: > > The SC27XX fuel gauge supports a low voltage alarm IRQ, which is used > > for more accurate battery capacity measurements with lower voltages. > > > > This was unfortunately never documented in bindings, do so now. > > > > Signed-off-by: Stanislav Jakubek <stano.jakubek@xxxxxxxxx> > > --- > > Initial Linux driver submission adding this feature: > > https://lore.kernel.org/lkml/ee1dd39f126bd03fb88381de9663d32df994d341.1542185618.git.baolin.wang@xxxxxxxxxx/ > > > > The only in-tree user (sc2731.dtsi) has had interrupts specified since its > > initial fuel-gauge submission: > > https://lore.kernel.org/lkml/4f66af3b47ba241380f8092e08879aca6d7c35b3.1548052878.git.baolin.wang@xxxxxxxxxx/ > > This context could go into the commit message I think, as justification > for making the interrupt required. TBH I'm not 100% sure that the interrupt is required, I just looked at the Linux driver, and that it returns from probe if it doesn't get the IRQ. > > Also, this binding is odd in that it has several compatibles in an enum, > but the driver (added at the same time) only has one compatible in it. I think the intent was to document the entire sc27xx series of PMICs, as they're supposedly very similar (this is just my guess), while initially adding support only for sc2731. > Are you using the sc2731 in your device? No, I do not have any such device. Regards, Stanislav
