On 15.08.24 14:32, Nishanth Menon wrote: > On 09:05-20240814, Judith Mendez wrote: >> Hi all, >> >> On 8/13/24 6:03 PM, Judith Mendez wrote: >>> Add Error Signaling Module (ESM) instances in MCU and MAIN >>> domains, set ESM interrupt sources for rti as per TRM [0] 9.4 >>> Interrupt Sources. >>> >>> Add comments to describe what interrupt sources are routed to >>> ESM modules. >>> >>> [0] https://www.ti.com/lit/ug/spruid7e/spruid7e.pdf > > As mentioned[1], please update the commit message > >>> >>> Signed-off-by: Judith Mendez <jm@xxxxxx> >>> --- >>> Changes since v1: >>> - Add patch 6/6 for am65x >>> --- >>> arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 8 ++++++++ >>> arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi | 8 ++++++++ >>> 2 files changed, 16 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi >>> index 1af3dedde1f67..07c9f043dac0b 100644 >>> --- a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi >>> +++ b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi >>> @@ -54,6 +54,14 @@ gic_its: msi-controller@1820000 { >>> }; >>> }; >>> + main_esm: esm@700000 { >>> + compatible = "ti,j721e-esm"; >>> + reg = <0x00 0x700000 0x00 0x1000>; >>> + /* Interrupt sources: rti0, rti1, rti2, rti3 */ >>> + ti,esm-pins = <224>, <225>, <226>, <227>; >> >> I am not sure if someone knows the answer to this question, but.. >> >> I noticed that for rti, the interrupt source id's are different >> for SR1 vs SR2, so which should be used here in k3-am65-main? >> >> Here, I assumed SR2. > > The only production board with SR1.0 that I am aware of is > arch/arm64/boot/dts/ti/k3-am65-iot2050-common-pg1.dtsi I think - Jan can > clarify. The technique used is to do an override in the dtsi if I am not > mistaken. > > [1] https://lore.kernel.org/all/20240815122928.4i2yob5aj5ssqhzw@reply/ Yes, we have to boards with SR1.0 in field, k3-am6528-iot2050-basic.dts and k3-am6548-iot2050-advanced.dts (which include the above dtsi). But given that AM65 is not benefiting from all these changes anyway if I got the reply correctly, why do we care? Jan -- Siemens AG, Technology Linux Expert Center
