> -----Original Message----- > From: Rob Herring (Arm) <robh@xxxxxxxxxx> > Sent: Tuesday, August 13, 2024 12:12 PM > To: Agarwal, Utsav <Utsav.Agarwal@xxxxxxxxxx> > Cc: devicetree@xxxxxxxxxxxxxxx; Hennerich, Michael > <Michael.Hennerich@xxxxxxxxxx>; Gaskell, Oliver > <Oliver.Gaskell@xxxxxxxxxx>; Conor Dooley <conor+dt@xxxxxxxxxx>; Sa, Nuno > <Nuno.Sa@xxxxxxxxxx>; linux-kernel@xxxxxxxxxxxxxxx; Bimpikas, Vasileios > <Vasileios.Bimpikas@xxxxxxxxxx>; Conor Dooley > <conor.dooley@xxxxxxxxxxxxx>; Artamonovs, Arturs > <Arturs.Artamonovs@xxxxxxxxxx>; Krzysztof Kozlowski <krzk+dt@xxxxxxxxxx>; > linux-input@xxxxxxxxxxxxxxx; Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx> > Subject: Re: [PATCH v10 3/3] dt-bindings: input: pure gpio support for adp5588 > > [External] > > > On Tue, 13 Aug 2024 10:51:33 +0100, Utsav Agarwal wrote: > > Adding software support for enabling the pure gpio capability of the > > device - which allows all I/O to be used as GPIO. Previously, I/O > > configuration was limited by software to partial GPIO support only. > > > > When working in a pure gpio mode, the device does not require the > > certain properties and hence, the following are now made optional: > > - interrupts > > - keypad,num-rows > > - keypad,num-columns > > - linux,keymap > > > > However, note that the above are required to be specified when > > configuring the device as a keypad, for which dependencies have been added > > such that specifying either one requires the remaining as well. > > > > Also, note that interrupts are made optional, but required when the device > > has either been configured in keypad mode or as an interrupt controller. > > This has been done since they may not necessarily be used when leveraging > > the device purely for GPIO. > > > > Acked-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx> > > Signed-off-by: Utsav Agarwal <utsav.agarwal@xxxxxxxxxx> > > --- > > .../devicetree/bindings/input/adi,adp5588.yaml | 40 ++++++++++++++++++- > --- > > 1 file changed, 34 insertions(+), 6 deletions(-) > > > > My bot found errors running 'make dt_binding_check' on your patch: > > yamllint warnings/errors: > ./Documentation/devicetree/bindings/input/adi,adp5588.yaml:140:1: [error] > syntax error: could not find expected ':' (syntax) > > dtschema/dtc warnings/errors: > /builds/robherring/dt-review- > ci/linux/Documentation/devicetree/bindings/input/adi,adp5588.yaml: ignoring, > error parsing file > ./Documentation/devicetree/bindings/input/adi,adp5588.yaml:140:1: could not > find expected ':' > make[2]: *** Deleting file > 'Documentation/devicetree/bindings/input/adi,adp5588.example.dts' > Documentation/devicetree/bindings/input/adi,adp5588.yaml:140:1: could not > find expected ':' > make[2]: *** [Documentation/devicetree/bindings/Makefile:26: > Documentation/devicetree/bindings/input/adi,adp5588.example.dts] Error 1 > make[2]: *** Waiting for unfinished jobs.... > make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1432: > dt_binding_check] Error 2 > make: *** [Makefile:224: __sub-make] Error 2 > Apologies, it seems like I accidently deleted the characters towards the end of the yaml file when making changes... I will resubmit the correct version, however, will wait a bit more in case any further feedback is required to be addressed. > doc reference errors (make refcheckdocs): > > See > https://urldefense.com/v3/__https://patchwork.ozlabs.org/project/devicetree- > bindings/patch/20240813-adp5588_gpio_support-v10-3- > aab3c52cc8bf@analog.com__;!!A3Ni8CS0y2Y!4tbdOq23VmmmlMgKDLoDULOV > eThzR4nvCvIk8I7bZCtjY3uTC2j_s4VxQaHIy7PdTr2iKLCA8JvR2eRX$ > > The base for the series is generally the latest rc1. A different dependency > should be noted in *this* patch. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit after running the above command yourself. Note > that DT_SCHEMA_FILES can be set to your schema file to speed up checking > your schema. However, it must be unset to test all examples with your schema. - Utsav
