On 13/08/2024 03:53, Ryan Chen wrote:
>> Drop the define for number of clocks from the header, because it is not a
*NUMBER OF CLOCKS*
>> binding. You can put it in the driver or not, I don't care and do not provide
>> guidance on this because I don't know if it makes sense at all.
>> What I know is that number of clocks is not related to binding. It is not needed
*NUMBER OF CLOCKS*
>> in the binding, either.
>
> Sorry, I am confused.
> if you think that number of clocks is not related to binding.
*NUMBER OF CLOCKS*
> How dtsi claim for clk?
> For example in dtsi.
> include <dt-bindings/clock/aspeed,ast2700-clk.h>
> usb3bhp: usb3bhp {
> ....
> clocks = <&syscon0 SCU0_CLK_GATE_PORTAUSB>;
And where is *NUMBER OF CLOCKS* here? I don't see any problem. No
useless SCU0_CLK_GATE_NUM define here.
> ...
> }
>
> It need for dtsi binding include for clock enable.
>
> If there is no binding clock include file, how device know the clock index?
Just look how ALL other bindings for new platforms are doing it. Why are
we discussing obvious kernel aspects? Spend time to read other drivers
before posting yours.
Best regards,
Krzysztof
