Hi Rob Herring, > -----Original Message----- > From: Rob Herring <robh@xxxxxxxxxx> > Sent: Friday, August 9, 2024 11:40 PM > To: Havalige, Thippeswamy <thippeswamy.havalige@xxxxxxx> > Cc: lpieralisi@xxxxxxxxxx; kw@xxxxxxxxx; bhelgaas@xxxxxxxxxx; > krzk+dt@xxxxxxxxxx; conor+dt@xxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; > devicetree@xxxxxxxxxxxxxxx; linux-pci@xxxxxxxxxxxxxxx; Havalige, > Thippeswamy <thippeswamy.havalige@xxxxxxx>; linux-arm- > kernel@xxxxxxxxxxxxxxxxxxx; Simek, Michal <michal.simek@xxxxxxx> > Subject: Re: [PATCH v3 1/2] dt-bindings: PCI: xilinx-xdma: Add schemas for > Xilinx QDMA PCIe Root Port Bridge > > On Fri, Aug 09, 2024 at 11:39:54AM +0530, Thippeswamy Havalige wrote: > > Add YAML devicetree schemas for Xilinx QDMA Soft IP PCIe Root Port > > Bridge. > > > > Signed-off-by: Thippeswamy Havalige <thippesw@xxxxxxx> > > --- > > .../devicetree/bindings/pci/xlnx,xdma-host.yaml | 36 > ++++++++++++++++++++-- > > 1 file changed, 34 insertions(+), 2 deletions(-) > > --- > > changes in v3 > > - constrain the new entry to only the new compatible. > > - Remove example. > > > > changes in v2 > > - update dt node label with pcie. > > --- > > diff --git a/Documentation/devicetree/bindings/pci/xlnx,xdma-host.yaml > b/Documentation/devicetree/bindings/pci/xlnx,xdma-host.yaml > > index 2f59b3a..f1efd919 100644 > > --- a/Documentation/devicetree/bindings/pci/xlnx,xdma-host.yaml > > +++ b/Documentation/devicetree/bindings/pci/xlnx,xdma-host.yaml > > @@ -14,10 +14,21 @@ allOf: > > > > properties: > > compatible: > > - const: xlnx,xdma-host-3.00 > > + enum: > > + - xlnx,xdma-host-3.00 > > + - xlnx,qdma-host-3.00 > > Kind of odd that both IP have the exact same version number. Please > explain in the commit message where it comes from. If you just copied it > from the previous one, then nak. When QDMA IP bought up we were using 3.0 version initially so the compatible String is xlnx,qdma-host-3.00 > > > > > reg: > > - maxItems: 1 > > + items: > > + - description: configuration region and XDMA bridge register. > > + - description: QDMA bridge register. > > + minItems: 1 > > + > > + reg-names: > > + items: > > + - const: cfg > > + - const: breg > > + minItems: 1 > > > > ranges: > > maxItems: 2 > > @@ -76,6 +87,27 @@ required: > > - "#interrupt-cells" > > - interrupt-controller > > > > +if: > > + properties: > > + compatible: > > + contains: > > + enum: > > + - xlnx,qdma-host-3.00 > > +then: > > + properties: > > + reg: > > + minItems: 2 > > + reg-names: > > + minItems: 2 > > + required: > > + - reg-names > > +else: > > + properties: > > + reg: > > + maxItems: 1 > > + reg-names: > > + maxItems: 1 > > + > > unevaluatedProperties: false > > > > examples: > > -- > > 1.8.3.1 > >
