Hi Manivannan, kernel test robot noticed the following build warnings: [auto build test WARNING on 8400291e289ee6b2bf9779ff1c83a291501f017b] url: https://github.com/intel-lab-lkp/linux/commits/Manivannan-Sadhasivam-via-B4-Relay/PCI-qcom-ep-Drop-the-redundant-masking-of-global-IRQ-events/20240802-024847 base: 8400291e289ee6b2bf9779ff1c83a291501f017b patch link: https://lore.kernel.org/r/20240731-pci-qcom-hotplug-v3-5-a1426afdee3b%40linaro.org patch subject: [PATCH v3 05/13] PCI: endpoint: Assign PCI domain number for endpoint controllers config: x86_64-randconfig-161-20240810 (https://download.01.org/0day-ci/archive/20240811/202408110938.hFwAHjZo-lkp@xxxxxxxxx/config) compiler: clang version 18.1.5 (https://github.com/llvm/llvm-project 617a15a9eac96088ae5e9134248d8236e34b91b1) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Closes: https://lore.kernel.org/oe-kbuild-all/202408110938.hFwAHjZo-lkp@xxxxxxxxx/ smatch warnings: drivers/pci/endpoint/pci-epc-core.c:914 __pci_epc_create() warn: inconsistent indenting vim +914 drivers/pci/endpoint/pci-epc-core.c 870 871 /** 872 * __pci_epc_create() - create a new endpoint controller (EPC) device 873 * @dev: device that is creating the new EPC 874 * @ops: function pointers for performing EPC operations 875 * @owner: the owner of the module that creates the EPC device 876 * 877 * Invoke to create a new EPC device and add it to pci_epc class. 878 */ 879 struct pci_epc * 880 __pci_epc_create(struct device *dev, const struct pci_epc_ops *ops, 881 struct module *owner) 882 { 883 int ret; 884 struct pci_epc *epc; 885 886 if (WARN_ON(!dev)) { 887 ret = -EINVAL; 888 goto err_ret; 889 } 890 891 epc = kzalloc(sizeof(*epc), GFP_KERNEL); 892 if (!epc) { 893 ret = -ENOMEM; 894 goto err_ret; 895 } 896 897 mutex_init(&epc->lock); 898 mutex_init(&epc->list_lock); 899 INIT_LIST_HEAD(&epc->pci_epf); 900 901 device_initialize(&epc->dev); 902 epc->dev.class = &pci_epc_class; 903 epc->dev.parent = dev; 904 epc->dev.release = pci_epc_release; 905 epc->ops = ops; 906 907 #ifdef CONFIG_PCI_DOMAINS_GENERIC 908 epc->domain_nr = pci_bus_find_domain_nr(NULL, dev); 909 #else 910 /* 911 * TODO: If the architecture doesn't support generic PCI 912 * domains, then a custom implementation has to be used. 913 */ > 914 WARN_ONCE(1, "This architecture doesn't support generic PCI domains\n"); 915 #endif 916 917 ret = dev_set_name(&epc->dev, "%s", dev_name(dev)); 918 if (ret) 919 goto put_dev; 920 921 ret = device_add(&epc->dev); 922 if (ret) 923 goto put_dev; 924 925 epc->group = pci_ep_cfs_add_epc_group(dev_name(dev)); 926 927 return epc; 928 929 put_dev: 930 put_device(&epc->dev); 931 932 err_ret: 933 return ERR_PTR(ret); 934 } 935 EXPORT_SYMBOL_GPL(__pci_epc_create); 936 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki