On Fri, Aug 09, 2024 at 04:49:14PM +0200, Francesco Dolcini wrote: > On Fri, Aug 09, 2024 at 03:27:39PM +0100, Conor Dooley wrote: > > On Fri, Aug 09, 2024 at 11:48:02AM +0200, Francesco Dolcini wrote: > > > From: Francesco Dolcini <francesco.dolcini@xxxxxxxxxxx> > > > > > > Add fsl,pps-channel property to specify to which timer instance the PPS > > > channel is connected to. > > > > In the driver patch you say "depending on the soc ... might be routed to > > different timer instances", why is a soc-specific compatible > > insufficient to determine which timer instance is in use? > > I think I know what you mean, but I'm not 100%. > > > > That said, the explanation in the driver patch is better than the one > > here, so a commit message improvement is required. > > This was clarified by NXP during the discussion on this series [1] and the > commit messages were not amended to take this new information into > account, my fault. > > I would propose something like this here: > > ``` > Add fsl,pps-channel property to select where to connect the PPS > signal. This depends on the internal SoC routing and on the board, for > example on the i.MX8 SoC it can be connected to an external pin (using > channel 1) or to internal eDMA as DMA request (channel 0). > ``` That's definitely better, as it illustrates why the compatible is not sufficient.
Attachment:
signature.asc
Description: PGP signature
