On 08/08/2024 11:38, FUKAUMI Naoki wrote: > - move pinctrl properties > - sort properties > - add default-state > > Signed-off-by: FUKAUMI Naoki <naoki@xxxxxxxxx> > --- > arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts b/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts > index 59f1403b4fa5..4fd6096f16ea 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts > +++ b/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts > @@ -42,14 +42,15 @@ gmac1_clkin: external-gmac1-clock { > > leds { > compatible = "gpio-leds"; > + pinctrl-names = "default"; > + pinctrl-0 = <&led_user_en>; Weird order. names never precede the property. Best regards, Krzysztof