the standard definition of LEDs for Radxa boards are: color = <LED_COLOR_ID_xxx>; [1] default-state = "on"; [2] function = LED_FUNCTION_xxx [1] [3] gpios = <&gpioX RK_Pxx GPIO_ACTIVE_xxx>; linux,default-trigger = "xxx"; [3] pinctrl-names = "default"; [4] pinctrl-0 = <&xxx>; [4] [1] use "color:function" instead of `label = "xxx:yyy:zzz"` [2] all LEDs should be turned on at U-Boot [3] if trigger is "heartbeat", FUNCTION should be HEARTBEAT [4] if it's SOM and carrier board, put pinctrl properties here if it's SBC, put them under `compatible = "gpio-leds"` FUKAUMI Naoki (10): arm64: dts: rockchip: standardize the definition of LEDs for Radxa ROCK Pi S arm64: dts: rockchip: standardize the definition of LEDs for Radxa ROCK Pi E arm64: dts: rockchip: standardize the definition of LEDs for Radxa ROCK 4C+ arm64: dts: rockchip: standardize the definition of LEDs for Radxa ROCK Pi 4 arm64: dts: rockchip: standardize the definition of LEDs for Radxa CM3 IO arm64: dts: rockchip: standardize the definition of LEDs for Radxa ROCK 3C arm64: dts: rockchip: standardize the definition of LEDs for Radxa E25 arm64: dts: rockchip: standardize the definition of LEDs for Radxa ROCK 3A arm64: dts: rockchip: standardize the definition of LEDs for Radxa ROCK 5B arm64: dts: rockchip: standardize the definition of LEDs for Radxa ROCK 5A arch/arm64/boot/dts/rockchip/rk3308-rock-pi-s.dts | 4 +--- arch/arm64/boot/dts/rockchip/rk3328-rock-pi-e.dtsi | 4 +++- arch/arm64/boot/dts/rockchip/rk3399-rock-4c-plus.dts | 6 ++++-- arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dtsi | 3 ++- arch/arm64/boot/dts/rockchip/rk3566-radxa-cm3-io.dts | 5 +++-- arch/arm64/boot/dts/rockchip/rk3566-radxa-cm3.dtsi | 6 +++--- arch/arm64/boot/dts/rockchip/rk3566-rock-3c.dts | 9 +++++---- arch/arm64/boot/dts/rockchip/rk3568-radxa-cm3i.dtsi | 5 +++-- arch/arm64/boot/dts/rockchip/rk3568-radxa-e25.dts | 7 ++++--- arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts | 9 +++++---- arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts | 3 ++- arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts | 3 ++- 12 files changed, 37 insertions(+), 27 deletions(-) -- 2.43.0