Re: [PATCH 07/10] arm64: dts: rockchip: standardize the definition of LEDs for Radxa E25

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 08/08/2024 11:38, FUKAUMI Naoki wrote:
> - sort properties
> - add default-state
> - add function for multi-led
> - remove redundant parameters from pwms

This does not match commit subject at all. Anyway, one commit per
logical change. Trivial cleanups are not per board, but per entire
subsystem. Changes with impact can be per board.

The way you split your work makes review, bisecting and backporting
unnecessary difficult. It's not even logical. There is no logical change
like "I will do 10 things for board X".

Best regards,
Krzysztof





[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux