On 08/08/2024 11:38, FUKAUMI Naoki wrote:
> - sort properties
You mean un-sort?!?!
> - add default-state and function
Commit subject is totally wrong. Sorry, write specific subjects
describing what you are doing. There is no standardization happening
here, whatever that means.
>
> Signed-off-by: FUKAUMI Naoki <naoki@xxxxxxxxx>
> ---
> arch/arm64/boot/dts/rockchip/rk3328-rock-pi-e.dtsi | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3328-rock-pi-e.dtsi b/arch/arm64/boot/dts/rockchip/rk3328-rock-pi-e.dtsi
> index bb01143dc91a..4e77701f2e01 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3328-rock-pi-e.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3328-rock-pi-e.dtsi
> @@ -49,11 +49,13 @@ gmac_clkin: external-gmac-clock {
>
> leds {
> compatible = "gpio-leds";
> - pinctrl-0 = <&led_pin>;
> pinctrl-names = "default";
> + pinctrl-0 = <&led_pin>;
Nope, that's wrong order.
>
Best regards,
Krzysztof
