Re: [PATCH net-next 1/2] dt-bindings: net: dsa: microchip: add microchip,no-tag-protocol flag

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed 6 Aug 2024 at 19:17, Rob Herring <robh@xxxxxxxxxx> wrote:
>
> On Thu, Aug 01, 2024 at 02:31:42PM +0200, vtpieter@xxxxxxxxx wrote:
> > From: Pieter Van Trappen <pieter.van.trappen@xxxxxxx>
> >
> > Add microchip,no-tag-protocol flag to allow disabling the switch'
>
> What is the ' for?
Typo
>
> > tagging protocol. For cases where the CPU MAC does not support MTU
> > size > 1500 such as the Zynq GEM.
>
> What is "switch tag protocol"? Not defined anywhere? Is that VLAN
> tagging?
>
> It seems to me that this doesn't need to be in DT. You know you have
> Zynq GEM because it should have a specific compatible. If it doesn't
> support some feature, then that should get propagated to the switch
> somehow.

Hi Rob, indeed and as indicated by Vladimir Oltean in a reply to this
patch, such a property exists already, dsa-port's `dsa-tag-protocol`.

Driver support is to be added but rather I'm changing the Zynq GEM
driver to support MTU > 1500 as in fact it turns our the harware does.

Pieter

>
> Rob




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux