Re: [PATCH v3 9/9] arm64: dts: ti: Add support for J742S2 EVM board

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 15:11-20240807, Beleswar Prasad Padhi wrote:
> For series,
> Reviewed-By: Beleswar Padhi <b-padhi@xxxxxx>
[...]
> > +/ {
> > +	model = "Texas Instruments J742S2 EVM";
> > +	compatible = "ti,j742s2-evm", "ti,j742s2";
> > +
> > +	memory@80000000 {
> > +		device_type = "memory";
> > +		bootph-all;
> > +		/* 16G RAM */
> > +		reg = <0x00000000 0x80000000 0x00000000 0x80000000>,
> > +		      <0x00000008 0x80000000 0x00000003 0x80000000>;

Sigh.. https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/dts-coding-style.rst#n117

1. "compatible" <- not present
2. "reg" <- present
3. "ranges" <- not present
4. Standard/common properties (defined by common bindings, e.g. without
   vendor-prefixes) <- bootph-all and device_type
5. Vendor-specific properties -> not present
6. "status" (if applicable) -> not present
7. Child nodes, where each node is preceded with a blank line -> not
present

So:

	/* 16G RAM */
	reg = <0x00000000 0x80000000 0x00000000 0x80000000>,
	      <0x00000008 0x80000000 0x00000003 0x80000000>;
	device_type = "memory";
	bootph-all;

??

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux