Hi Udit,
On 12:58-20240807, Kumar, Udit wrote:
>
> On 7/30/2024 3:23 PM, Manorit Chawdhry wrote:
> > Adds bootph-* properties to the leaf nodes to enable U-boot to
> > utilise them.
> >
> > Signed-off-by: Manorit Chawdhry <m-chawdhry@xxxxxx>
> > ---
> > .../arm64/boot/dts/ti/k3-j7200-common-proc-board.dts | 20 ++++++++++++++++++++
> > arch/arm64/boot/dts/ti/k3-j7200-main.dtsi | 2 ++
> > arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi | 10 ++++++++++
> > arch/arm64/boot/dts/ti/k3-j7200-som-p0.dtsi | 7 +++++++
> > 4 files changed, 39 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts
> > index 6593c5da82c0..ec522595fc83 100644
> > --- a/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts
> > +++ b/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts
> > [..]
> >
> > diff --git a/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi b/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi
> > index 9386bf3ef9f6..b95656942412 100644
> > --- a/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi
> > +++ b/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi
> > @@ -136,6 +136,7 @@ secure_proxy_main: mailbox@32c00000 {
> > <0x00 0x32800000 0x00 0x100000>;
> > interrupt-names = "rx_011";
> > interrupts = <GIC_SPI 37 IRQ_TYPE_LEVEL_HIGH>;
> > + bootph-all;
> > };
> > hwspinlock: spinlock@30e00000 {
> > @@ -1528,5 +1529,6 @@ main_esm: esm@700000 {
> > compatible = "ti,j721e-esm";
> > reg = <0x0 0x700000 0x0 0x1000>;
> > ti,esm-pins = <656>, <657>;
> > + bootph-all;
>
> Should be bootph-pre-ram
>
> if you think otherwise then please update mcu_esm
Will update to bootph-pre-ram;
>
[..]
> > @@ -45,6 +48,7 @@ mcu_timer0: timer@40400000 {
> > assigned-clock-parents = <&k3_clks 35 2>;
> > power-domains = <&k3_pds 35 TI_SCI_PD_EXCLUSIVE>;
> > ti,timer-pwm;
> > + bootph-pre-ram;
>
> I see this node is marked as reserved
>
> Do we plan to use in bootloader ?
mcu_timer0 is used in R5 stage [0].
[0]: https://github.com/u-boot/u-boot/blob/master/arch/arm/dts/k3-j7200-r5-common-proc-board.dts#L56
>
> > };
[..]
> > hbmc: hyperbus@47034000 {
>
> I think you should consider to mark hbmc node for boot phase as well
>
It's already marked in k3-j7200-som-p0.dtsi file with bootph-all inside
the flash node that describe it, is that okay?
>
> > @@ -652,6 +661,7 @@ wkup_vtm0: temperature-sensor@42040000 {
> > <0x00 0x42050000 0x00 0x350>;
> > power-domains = <&k3_pds 154 TI_SCI_PD_EXCLUSIVE>;
> > #thermal-sensor-cells = <1>;
> > + bootph-pre-ram;
> > };
> > mcu_esm: esm@40800000 {
> > diff --git a/arch/arm64/boot/dts/ti/k3-j7200-som-p0.dtsi b/arch/arm64/boot/dts/ti/k3-j7200-som-p0.dtsi
> > index 21fe194a5766..d78f86889bf9 100644
> > --- a/arch/arm64/boot/dts/ti/k3-j7200-som-p0.dtsi
> > +++ b/arch/arm64/boot/dts/ti/k3-j7200-som-p0.dtsi
> > @@ -121,6 +121,7 @@ J721E_WKUP_IOPAD(0x20, PIN_INPUT, 1) /* (B8) MCU_OSPI0_D5.MCU_HYPERBUS0_DQ5 */
> > J721E_WKUP_IOPAD(0x24, PIN_INPUT, 1) /* (A8) MCU_OSPI0_D6.MCU_HYPERBUS0_DQ6 */
> > J721E_WKUP_IOPAD(0x28, PIN_INPUT, 1) /* (A7) MCU_OSPI0_D7.MCU_HYPERBUS0_DQ7 */
> > >;
> > [..]
> > bucka2: buck2 {
> > @@ -464,6 +470,7 @@ flash@0 {
> > cdns,tchsh-ns = <60>;
> > cdns,tslch-ns = <60>;
> > cdns,read-delay = <4>;
> > + bootph-all;
> > partitions {
> > compatible = "fixed-partitions";
>
>
> Please consider, adding bootph in ospi0 node as well around
> "ospi.phypattern"
>
Okay sure, will move the bootph-all from flash@0 node to under
ospi.phypattern node as putting it in the child node should propagate
it.
Thanks for reviewing Udit!
Regards,
Manorit
>
> >
