Re: [PATCH] dt-bindings: timer: nxp,lpc3220-timer: Convert to dtschema

[Vladimir Zapolskiy <vz@xxxxxxxxx>]

On 7/31/24 10:45, Animesh Agarwal wrote:
> Convert the NXP LPC3220 timer bindings to yaml format.
> Add missing resets property as it is already being used in dts.
>
> Cc: Daniel Baluta <daniel.baluta@xxxxxxx>
> Signed-off-by: Animesh Agarwal <animeshagarwal28@xxxxxxxxx>
> ---
>   .../bindings/timer/nxp,lpc3220-timer.txt      | 26 ---------
>   .../bindings/timer/nxp,lpc3220-timer.yaml     | 55 +++++++++++++++++++
>   2 files changed, 55 insertions(+), 26 deletions(-)
>   delete mode 100644 Documentation/devicetree/bindings/timer/nxp,lpc3220-timer.txt
>   create mode 100644 Documentation/devicetree/bindings/timer/nxp,lpc3220-timer.yaml
>
> diff --git a/Documentation/devicetree/bindings/timer/nxp,lpc3220-timer.txt b/Documentation/devicetree/bindings/timer/nxp,lpc3220-timer.txt
> deleted file mode 100644
> index 51b05a0e70d1..000000000000
> --- a/Documentation/devicetree/bindings/timer/nxp,lpc3220-timer.txt
> +++ /dev/null
> @@ -1,26 +0,0 @@
> -* NXP LPC3220 timer
> -
> -The NXP LPC3220 timer is used on a wide range of NXP SoCs. This
> -includes LPC32xx, LPC178x, LPC18xx and LPC43xx parts.
> -
> -Required properties:
> -- compatible:
> -	Should be "nxp,lpc3220-timer".
> -- reg:
> -	Address and length of the register set.
> -- interrupts:
> -	Reference to the timer interrupt
> -- clocks:
> -	Should contain a reference to timer clock.
> -- clock-names:
> -	Should contain "timerclk".
> -
> -Example:
> -
> -timer1: timer@40085000 {
> -	compatible = "nxp,lpc3220-timer";
> -	reg = <0x40085000 0x1000>;
> -	interrupts = <13>;
> -	clocks = <&ccu1 CLK_CPU_TIMER1>;
> -	clock-names = "timerclk";
> -};
> diff --git a/Documentation/devicetree/bindings/timer/nxp,lpc3220-timer.yaml b/Documentation/devicetree/bindings/timer/nxp,lpc3220-timer.yaml
> new file mode 100644
> index 000000000000..3ae2eb0625da
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/timer/nxp,lpc3220-timer.yaml
> @@ -0,0 +1,55 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/timer/nxp,lpc3220-timer.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: NXP LPC3220 timer
> +
> +maintainers:
> +  - Animesh Agarwal <animeshagarwal28@xxxxxxxxx>
> +
> +description: |
> +  The NXP LPC3220 timer is used on a wide range of NXP SoCs. This includes
> +  LPC32xx, LPC178x, LPC18xx and LPC43xx parts.
> +
> +properties:
> +  compatible:
> +    const: nxp,lpc3220-timer
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  clocks:
> +    maxItems: 1
> +
> +  clock-names:
> +    const: timerclk
> +
> +  resets:
> +    maxItems: 1
> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +  - clocks
> +  - clock-names

Since there is always just a single supply clock, there is no need to
specify "clock-names" as a required one, please change it.

> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/clock/lpc32xx-clock.h>
> +    #include <dt-bindings/interrupt-controller/irq.h>
> +
> +    timer@4004c000 {
> +        compatible = "nxp,lpc3220-timer";
> +        reg = <0x4004c000 0x1000>;
> +        interrupts = <17 IRQ_TYPE_LEVEL_LOW>;
> +        clocks = <&clk LPC32XX_CLK_TIMER1>;
> +        clock-names = "timerclk";
> +    };

I would appreciate, if you can use scripts/get_maintainer.pl in future.

--
Best wishes,
Vladimir