On 30/07/2024 14:32, Markus Schneider-Pargmann wrote: > Hi Nishanth, > > On Tue, Jul 30, 2024 at 07:09:58AM GMT, Nishanth Menon wrote: >> On 10:00-20240729, Markus Schneider-Pargmann wrote: >>> WKUP_EN is a flag to enable pin wakeup. Any activity will wakeup the SoC >>> in that case. >>> >>> Signed-off-by: Markus Schneider-Pargmann <msp@xxxxxxxxxxxx> >>> --- >>> arch/arm64/boot/dts/ti/k3-pinctrl.h | 3 +++ >>> 1 file changed, 3 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/ti/k3-pinctrl.h b/arch/arm64/boot/dts/ti/k3-pinctrl.h >>> index 22b8d73cfd32..dd4d53e8420a 100644 >>> --- a/arch/arm64/boot/dts/ti/k3-pinctrl.h >>> +++ b/arch/arm64/boot/dts/ti/k3-pinctrl.h >>> @@ -12,6 +12,7 @@ >>> #define PULLTYPESEL_SHIFT (17) >>> #define RXACTIVE_SHIFT (18) >>> #define DEBOUNCE_SHIFT (11) >>> +#define WKUP_EN_SHIFT (29) >>> >>> #define PULL_DISABLE (1 << PULLUDEN_SHIFT) >>> #define PULL_ENABLE (0 << PULLUDEN_SHIFT) >>> @@ -38,6 +39,8 @@ >>> #define PIN_DEBOUNCE_CONF5 (5 << DEBOUNCE_SHIFT) >>> #define PIN_DEBOUNCE_CONF6 (6 << DEBOUNCE_SHIFT) >>> >>> +#define WKUP_EN (1 << WKUP_EN_SHIFT) >>> + >> >> Are we using this? > > Yes, this needs to be used in pinctrl for the relevant pins. The users > are not part of this series, as it will probably be in devicetree > overlays or maybe future board files. You cannot add some code without users claiming that "someone, someday might need it". It's just dead code. Best regards, Krzysztof
