On Fri, Aug 02, 2024 at 09:25:54AM +0200, Krzysztof Kozlowski wrote:
> On 01/08/2024 18:09, Frank Li wrote:
> > From: Clark Wang <xiaoning.wang@xxxxxxx>
> >
> > Add lpi2c1 and child node for imx93-11x11-evk board.
>
> Why? What for? What are these? We see all this from the diff, so commit
> msg should explain why and what do you want to achieve.
I really don't know how to explain why/what for these straing forward
thing, hardware board has such component, just add it dts file.
>
> >
> > Signed-off-by: Clark Wang <xiaoning.wang@xxxxxxx>
> > Reviewed-by: Haibo Chen <haibo.chen@xxxxxxx>
> > Signed-off-by: Li Yang <leoyang.li@xxxxxxx>
> > Signed-off-by: Dong Aisheng <aisheng.dong@xxxxxxx>
> > Signed-off-by: Frank Li <Frank.Li@xxxxxxx>
> > ---
> > .../boot/dts/freescale/imx93-11x11-evk.dts | 21 +++++++++++++++++++
> > 1 file changed, 21 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts b/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
> > index a15987f49e8d6..dd387b820831a 100644
> > --- a/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
> > +++ b/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
> > @@ -145,6 +145,20 @@ ethphy2: ethernet-phy@2 {
> > };
> > };
> >
> > +&lpi2c1 {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > + clock-frequency = <400000>;
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&pinctrl_lpi2c1>;
> > + status = "okay";
> > +
> > + lsm6dsm@6a {
>
> Node names should be generic. See also an explanation and list of
> examples (not exhaustive) in DT specification:
> https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
I really sorry, I forget it again.
Frank
>
>
>
>
> Best regards,
> Krzysztof
>
