> On Fri, Aug 02, 2024 at 11:44:28AM +0300, Andrei Simion wrote: >> Based on the datasheet [1] (Block Diagram) PVIN[1-4] and LVIN >> represent the input voltage supply for each BUCKs respective LDOs. >> Update the driver to align with the datasheet [1]. >> >> [1]: https://ww1.microchip.com/downloads/en/DeviceDoc/MCP16502-High-Performance-PMIC-for-SAMA5DX-SAM9X6-MPUs-Data-Sheet-DS20006275A.pdf > I'd expect to see a matching update to the bindings. In regulator.yaml exists .*-supply [1] which practically allows every char sequence before -supply. In the binding microchip,mcp16502.yaml [2] each node under the regulators includes all the rules/documentation from regulator.yaml , so I supposed that it is unnecessary to add in the binding of those new property. What is your opinion? Let me know any thoughts. [1] https://github.com/torvalds/linux/blob/master/Documentation/devicetree/bindings/regulator/regulator.yaml#L244 [2] https://github.com/torvalds/linux/blob/master/Documentation/devicetree/bindings/regulator/microchip%2Cmcp16502.yaml#L39 Best Regards, Andrei Simion