On 31/07/2024 19:59, Danila Tikhonov wrote: > Add SM8475 GCC bindings, which are simply a symlink to the SM8450 > bindings. Update the documentation with the new compatible. > > Signed-off-by: Danila Tikhonov <danila@xxxxxxxxxxx> > --- > .../devicetree/bindings/clock/qcom,gcc-sm8450.yaml | 8 ++++++-- > include/dt-bindings/clock/qcom,gcc-sm8450.h | 2 ++ > include/dt-bindings/clock/qcom,sm8475-gcc.h | 1 + > 3 files changed, 9 insertions(+), 2 deletions(-) > create mode 120000 include/dt-bindings/clock/qcom,sm8475-gcc.h > > diff --git a/Documentation/devicetree/bindings/clock/qcom,gcc-sm8450.yaml b/Documentation/devicetree/bindings/clock/qcom,gcc-sm8450.yaml > index d848361beeb3..c7d75ee2a23b 100644 > --- a/Documentation/devicetree/bindings/clock/qcom,gcc-sm8450.yaml > +++ b/Documentation/devicetree/bindings/clock/qcom,gcc-sm8450.yaml > @@ -13,11 +13,15 @@ description: | > Qualcomm global clock control module provides the clocks, resets and power > domains on SM8450 > > - See also:: include/dt-bindings/clock/qcom,gcc-sm8450.h > + See also:: You can use one : (:: -> :). That was a mistake to use double colons. > + include/dt-bindings/clock/qcom,gcc-sm8450.h > + include/dt-bindings/clock/qcom,sm8475-gcc.h > > properties: > compatible: > - const: qcom,gcc-sm8450 > + enum: > + - qcom,gcc-sm8450 > + - qcom,sm8475-gcc > > clocks: > items: > diff --git a/include/dt-bindings/clock/qcom,gcc-sm8450.h b/include/dt-bindings/clock/qcom,gcc-sm8450.h > index 9679410843a0..5f1f9ab71a22 100644 > --- a/include/dt-bindings/clock/qcom,gcc-sm8450.h > +++ b/include/dt-bindings/clock/qcom,gcc-sm8450.h > @@ -194,6 +194,8 @@ > #define GCC_VIDEO_AXI0_CLK 182 > #define GCC_VIDEO_AXI1_CLK 183 > #define GCC_VIDEO_XO_CLK 184 > +#define GCC_GPLL2 185 > +#define GCC_GPLL3 186 Are these valid for sm8450? > > /* GCC resets */ > #define GCC_CAMERA_BCR 0 > diff --git a/include/dt-bindings/clock/qcom,sm8475-gcc.h b/include/dt-bindings/clock/qcom,sm8475-gcc.h > new file mode 120000 > index 000000000000..daafdd881892 > --- /dev/null > +++ b/include/dt-bindings/clock/qcom,sm8475-gcc.h If the bindings are the same... then why having separate header? I suggest dropping it. Best regards, Krzysztof
