Hello Danila. On 7/31/24 20:59, Danila Tikhonov wrote:
Add SM8475 GCC bindings, which are simply a symlink to the SM8450 bindings. Update the documentation with the new compatible. Signed-off-by: Danila Tikhonov <danila@xxxxxxxxxxx>
diff --git a/include/dt-bindings/clock/qcom,gcc-sm8450.h b/include/dt-bindings/clock/qcom,gcc-sm8450.h index 9679410843a0..5f1f9ab71a22 100644 --- a/include/dt-bindings/clock/qcom,gcc-sm8450.h +++ b/include/dt-bindings/clock/qcom,gcc-sm8450.h @@ -194,6 +194,8 @@ #define GCC_VIDEO_AXI0_CLK 182 #define GCC_VIDEO_AXI1_CLK 183 #define GCC_VIDEO_XO_CLK 184 +#define GCC_GPLL2 185 +#define GCC_GPLL3 186
To avoid any probable confusion related to the list of clocks on SM8450 platform let's add a new header file.
/* GCC resets */ #define GCC_CAMERA_BCR 0 diff --git a/include/dt-bindings/clock/qcom,sm8475-gcc.h b/include/dt-bindings/clock/qcom,sm8475-gcc.h new file mode 120000 index 000000000000..daafdd881892 --- /dev/null +++ b/include/dt-bindings/clock/qcom,sm8475-gcc.h @@ -0,0 +1 @@ +qcom,gcc-sm8450.h \ No newline at end of file
Instead of adding a symbolic link to the already existing header file please create a header file, which includes the old one: #include "qcom,gcc-sm8450.h" #define GCC_GPLL2 185 #define GCC_GPLL3 186 In drivers/clk/qcom/gcc-sm8450.c file along with new functional changes include the new header file instead of the old one. -- Best wishes, Vladimir
