Le mer. 31 juil. 2024 à 22:10, Simon Horman <horms@xxxxxxxxxx> a écrit : > > On Wed, Jul 31, 2024 at 12:34:00PM +0200, vtpieter@xxxxxxxxx wrote: > > From: Pieter Van Trappen <pieter.van.trappen@xxxxxxx> > > > > Move KSZ9477 WoL functions to ksz_common, in preparation for adding > > KSZ87xx family support. > > > > Signed-off-by: Pieter Van Trappen <pieter.van.trappen@xxxxxxx> > > Hi Pieter, > > This is not a full review, and I suggest waiting for feedback from others. > > However, I think this patch-set needs to be re-arranged a little, > perhaps by bringing forward some of the header file changes > in the following patch forward, either into this patch > or a new patch before it. Hi Simon, thanks indeed I missed this! It seems difficult to respect both patch requirements [1] for this case: * One significant exception is when moving code from one file to another -- in this case you should not modify the moved code at all in the same patch which moves it. * When dividing your change into a series of patches, take special care to ensure that the kernel builds and runs properly after each patch in the series. I can make it compile but by moving the code, the KSZ9477 WoL part obviously won't run properly anymore. Any suggestion how to tackle this? [1] : https://docs.kernel.org/process/submitting-patches.html > > In any case, the driver does not compile with this patch applied, > f.e. W=1 build using allmodconfig on x86_64. While it does > compile just fine when the following patch is applied. > > -- > pw-bot: changes-requested
