On Wed, Jul 31, 2024 at 12:34:00PM +0200, vtpieter@xxxxxxxxx wrote: > From: Pieter Van Trappen <pieter.van.trappen@xxxxxxx> > > Move KSZ9477 WoL functions to ksz_common, in preparation for adding > KSZ87xx family support. > > Signed-off-by: Pieter Van Trappen <pieter.van.trappen@xxxxxxx> Hi Pieter, This is not a full review, and I suggest waiting for feedback from others. However, I think this patch-set needs to be re-arranged a little, perhaps by bringing forward some of the header file changes in the following patch forward, either into this patch or a new patch before it. In any case, the driver does not compile with this patch applied, f.e. W=1 build using allmodconfig on x86_64. While it does compile just fine when the following patch is applied. -- pw-bot: changes-requested
