Hello Krzysztof, On 22/07/2024 11:47, Krzysztof Kozlowski wrote: > On 22/07/2024 11:41, ysionneau@xxxxxxxxxxxxx wrote: >> From: Yann Sionneau <ysionneau@xxxxxxxxxxxxx> >> >> Add binding for Kalray Coolidge SoC cluster power controller. >> >> Signed-off-by: Yann Sionneau <ysionneau@xxxxxxxxxxxxx> >> --- >> >> Notes: >> >> V2 -> V3: New patch >> --- >> .../soc/kvx/kalray,coolidge-pwr-ctrl.yaml | 37 +++++++++++++++++++ >> 1 file changed, 37 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/soc/kvx/kalray,coolidge-pwr-ctrl.yaml >> >> diff --git a/Documentation/devicetree/bindings/soc/kvx/kalray,coolidge-pwr-ctrl.yaml b/Documentation/devicetree/bindings/soc/kvx/kalray,coolidge-pwr-ctrl.yaml >> new file mode 100644 >> index 0000000000000..e0363a080ac11 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/soc/kvx/kalray,coolidge-pwr-ctrl.yaml >> @@ -0,0 +1,37 @@ >> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/kalray/kalray,coolidge-pwr-ctrl.yaml# > It does not look like you tested the bindings, at least after quick > look. Please run `make dt_binding_check` (see > Documentation/devicetree/bindings/writing-schema.rst for instructions). > Maybe you need to update your dtschema and yamllint. You are entirely correct, I *did* test the bindings at some point, but then in my last rounds of modifications I only ran make dtbs and make dtbs_check and completely forgot to re-run the `make dt_binding_check`. Sorry about that. We'll work on those again. Regards, PS: my dtschema and yamllint are up to date though. -- Yann
