Hello Jonathan, Thank you for the explanation ! We will construct the patch-set as you suggested. Since the rework of the driver still takes some time, we will send the new version once we finish it. Mit freundlichen Grüßen / Best regards Jianping Shen Mobility Electronics - Sensors, Engineering Advanced Development - MEMS Solutions Software (ME-SE/EAD2) Robert Bosch GmbH | Postfach 13 42 | 72703 Reutlingen | GERMANY | www.bosch.com Tel. +49 7121 35-37749 | Telefax +49 711 811-509378 | Jianping.Shen@xxxxxxxxxxxx Sitz: Stuttgart, Registergericht: Amtsgericht Stuttgart, HRB 14000; Aufsichtsratsvorsitzender: Prof. Dr. Stefan Asenkerschbaumer; Geschäftsführung: Dr. Stefan Hartung, Dr. Christian Fischer, Dr. Markus Forschner, Stefan Grosch, Dr. Markus Heyn, Dr. Frank Meyer, Dr. Tanja Rückert -----Original Message----- From: Jonathan Cameron <jic23@xxxxxxxxxx> Sent: Saturday, July 27, 2024 4:00 PM To: Conor Dooley <conor@xxxxxxxxxx> Cc: Shen Jianping (ME-SE/EAD2) <Jianping.Shen@xxxxxxxxxxxx>; Krzysztof Kozlowski <krzk@xxxxxxxxxx>; lars@xxxxxxxxxx; robh@xxxxxxxxxx; krzk+dt@xxxxxxxxxx; conor+dt@xxxxxxxxxx; dima.fedrau@xxxxxxxxx; marcelo.schmitt1@xxxxxxxxx; linux-iio@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Lorenz Christian (ME-SE/EAD2) <Christian.Lorenz3@xxxxxxxxxxxx>; Frauendorf Ulrike (ME/PJ-SW3) <Ulrike.Frauendorf@xxxxxxxxxxxx>; Dolde Kai (ME-SE/PAE-A3) <Kai.Dolde@xxxxxxxxxxxx> Subject: Re: [PATCH] dt-bindings: iio: imu: SMI240: add bosch,smi240.yaml On Wed, 24 Jul 2024 16:25:39 +0100 Conor Dooley <conor@xxxxxxxxxx> wrote: > On Wed, Jul 24, 2024 at 02:19:25PM +0000, Shen Jianping (ME-SE/EAD2) wrote: > > Anyway, please send bindings with driver in the same patchset. > > > > -> It's fine for us. Nevertheless according to the Devicetree (DT) > > -> binding submitting rules 1.1 > > > > " The Documentation/ and include/dt-bindings/ portion of the patch > > should be a separate patch." See -> > > https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fww > > w.kernel.org%2Fdoc%2Fhtml%2Flatest%2Fdevicetree%2Fbindings%2Fsubmitt > > ing-patches.html%23i-for-patch-submitters&data=05%7C02%7CJianping.Sh > > en%40de.bosch.com%7C3d03781ae4564e7e3f7708dcae447463%7C0ae51e1907c84 > > e4bbb6d648ee58410f4%7C0%7C0%7C638576856248420833%7CUnknown%7CTWFpbGZ > > sb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0 > > %3D%7C0%7C%7C%7C&sdata=OEaFoGpb%2F7CVAN2gEpNwG9I1zGBlUNYdLUy%2F7w5Dh > > b0%3D&reserved=0 > > > > Shall we still put the binding and driver in the same patch ? > > No, different patches please. Also, please fix your mail client so > that it quotes emails properly. To add a little more detail. We are looking for a cover letter and a pair of patches. 1st adds the dt-binding docs. 2nd provides the driver. The cover letter provides a brief summary of the whole series and provides a convenient name for tracking it as a whole. Take a look at how other recent driver addition patch series have been broken up. Jonathan
