On Fri, Jul 26, 2024 at 01:40:33PM GMT, Satya Priya Kakitapalli (Temp) wrote: > > On 7/9/2024 4:21 PM, Satya Priya Kakitapalli (Temp) wrote: > > > > On 7/3/2024 3:35 PM, Dmitry Baryshkov wrote: > > > On Tue, Jul 02, 2024 at 09:20:41PM GMT, Satya Priya Kakitapalli wrote: > > > > From: Taniya Das <quic_tdas@xxxxxxxxxxx> > > > > > > > > Regera PLL ops are required to control the Regera PLL from clock > > > > controller drivers, thus add support for the same. > > > the same what? > > > > > > I'll rephrase the commit text. > > > > > > > > Signed-off-by: Taniya Das <quic_tdas@xxxxxxxxxxx> > > > > Signed-off-by: Satya Priya Kakitapalli <quic_skakitap@xxxxxxxxxxx> > > > > --- > > > > drivers/clk/qcom/clk-alpha-pll.c | 32 > > > > +++++++++++++++++++++++++++++++- > > > > drivers/clk/qcom/clk-alpha-pll.h | 5 +++++ > > > > 2 files changed, 36 insertions(+), 1 deletion(-) [...] > > > > +EXPORT_SYMBOL_GPL(clk_regera_pll_configure); > > > Does it make sense to call this function from clk_zonda_pll_configure()? > > > > > > Okay, I'll evaluate this internally and see if that can be done. > > > > I have checked this, although there is common part between Zonda and Regera > PLL configure APIs, a different sequence needs to be followed for Zonda, and > calling this function from zonda_pll_configure would affect the sequence. > Hence, I think it is better to leave it as is. Ack. -- With best wishes Dmitry
