On Tue, 23 Jul 2024 at 14:11, Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> wrote: > > On Tue, 23 Jul 2024 at 02:24, Konrad Dybcio <konrad.dybcio@xxxxxxxxxx> wrote: > > > > On 22.07.2024 1:57 PM, Dmitry Baryshkov wrote: > > > Add gpio-keys device, responsible for a single button: Volume Up. > > > > > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> > > > --- > > > .../boot/dts/qcom/msm8998-lenovo-miix-630.dts | 25 ++++++++++++++++++++++ > > > 1 file changed, 25 insertions(+) > > > > > > diff --git a/arch/arm64/boot/dts/qcom/msm8998-lenovo-miix-630.dts b/arch/arm64/boot/dts/qcom/msm8998-lenovo-miix-630.dts > > > index f585bc8ba2ce..bca309ac0cb8 100644 > > > --- a/arch/arm64/boot/dts/qcom/msm8998-lenovo-miix-630.dts > > > +++ b/arch/arm64/boot/dts/qcom/msm8998-lenovo-miix-630.dts > > > + > > > + key-vol-up { > > > + label = "Volume Up"; > > > + linux,code = <KEY_VOLUMEUP>; > > > + gpios = <&pm8998_gpios 6 GPIO_ACTIVE_LOW>; > > > > No debounce-interval? > > Strangely enough, no. See existing defines. After more digging I see it being used. Let's use it too. -- With best wishes Dmitry