On Tue, 23 Jul 2024 at 02:24, Konrad Dybcio <konrad.dybcio@xxxxxxxxxx> wrote: > > On 22.07.2024 1:57 PM, Dmitry Baryshkov wrote: > > Add gpio-keys device, responsible for a single button: Volume Up. > > > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> > > --- > > .../boot/dts/qcom/msm8998-lenovo-miix-630.dts | 25 ++++++++++++++++++++++ > > 1 file changed, 25 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/qcom/msm8998-lenovo-miix-630.dts b/arch/arm64/boot/dts/qcom/msm8998-lenovo-miix-630.dts > > index f585bc8ba2ce..bca309ac0cb8 100644 > > --- a/arch/arm64/boot/dts/qcom/msm8998-lenovo-miix-630.dts > > +++ b/arch/arm64/boot/dts/qcom/msm8998-lenovo-miix-630.dts > > @@ -3,12 +3,27 @@ > > > > /dts-v1/; > > > > +#include <dt-bindings/pinctrl/qcom,pmic-gpio.h> > > #include "msm8998-clamshell.dtsi" > > > > / { > > model = "Lenovo Miix 630"; > > compatible = "lenovo,miix-630", "qcom,msm8998"; > > chassis-type = "convertible"; > > + > > + gpio-keys { > > + compatible = "gpio-keys"; > > + autorepeat; > > + > > + pinctrl-names = "default"; > > + pinctrl-0 = <&vol_up_pin_a>; > > property-n > property-names > > > + > > + key-vol-up { > > + label = "Volume Up"; > > + linux,code = <KEY_VOLUMEUP>; > > + gpios = <&pm8998_gpios 6 GPIO_ACTIVE_LOW>; > > No debounce-interval? Strangely enough, no. See existing defines. -- With best wishes Dmitry