Dear Sergei, Thanks very much for suggestion. I will fix them in the next version. On Fri, 2015-03-06 at 17:48 +0300, Sergei Shtylyov wrote: > Hello. > > On 3/6/2015 1:48 PM, yong.wu@xxxxxxxxxxxx wrote: > > > From: Yong Wu <yong.wu@xxxxxxxxxxxx> > > > This patch add smi binding document. > > > Signed-off-by: Yong Wu <yong.wu@xxxxxxxxxxxx> > > --- > > .../devicetree/bindings/soc/mediatek/mediatek,smi.txt | 17 +++++++++++++++++ > > 1 file changed, 17 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/soc/mediatek/mediatek,smi.txt > > > diff --git a/Documentation/devicetree/bindings/soc/mediatek/mediatek,smi.txt b/Documentation/devicetree/bindings/soc/mediatek/mediatek,smi.txt > > new file mode 100644 > > index 0000000..0fc9d1a > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/soc/mediatek/mediatek,smi.txt > > @@ -0,0 +1,17 @@ > > +SMI hardware block diagram please help check <bindings/iommu/mediatek,iommu.txt> > > + > > +Required properties: > > +- compatible : must be "mediatek,mediatek,mt8173-smi-larb" > > One "mediatek," is enough. :-) > > > +- reg : the register of each local arbiter > > +- clocks : the clocks of each local arbiter > > +- clock-name: larb_sub*(3 clockes at most) > > clock-names. > > > + > > +Example: > > + larb1:larb@16010000 { > > + compatible = "mediatek,mt8173-smi-larb"; > > + reg = <0 0x16010000 0 0x1000>; > > + clocks = <&mmsys MM_SMI_COMMON>, > > + <&vdecsys VDEC_CKEN>, > > Please align with the < above. > > > + <&vdecsys VDEC_LARB_CKEN>; > > Use tabs instead of spaces, please. > > > + clock-names = "larb_sub0", "larb_sub1", "larb_sub2"; > > + }; > > WBR, Sergei > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html