On Fri, Jul 19, 2024 at 12:03:21AM +0300, Ilya Orazov wrote:
> Microchip ATA6561 is High-Speed CAN Transceiver with Standby Mode.
> It is pin-compatible with TI TCAN1042.
>
> Signed-off-by: Ilya Orazov <ilordash02@xxxxxxxxx>
> ---
> Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml b/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml
> index 79dad3e89aa6..03de361849d2 100644
> --- a/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml
> +++ b/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml
> @@ -18,6 +18,7 @@ properties:
> - nxp,tjr1443
> - ti,tcan1042
> - ti,tcan1043
> + - microchip,ata6561
Given that your driver patch has
| diff --git a/drivers/phy/phy-can-transceiver.c b/drivers/phy/phy-can-transceiver.c
| index ee4ce4249698..dbcd99213ba1 100644
| --- a/drivers/phy/phy-can-transceiver.c
| +++ b/drivers/phy/phy-can-transceiver.c
| @@ -89,6 +89,10 @@ static const struct of_device_id can_transceiver_phy_ids[] = {
| .compatible = "nxp,tjr1443",
| .data = &tcan1043_drvdata
| },
| + {
| + .compatible = "microchip,ata6561",
| + .data = &tcan1042_drvdata
| + },
| { }
| };
the driver patch is actually not needed at all, and you just need to
allow ti,tcan1042 as fallback compatible in the binding, so something
like:
compatible:
oneOf:
- enum:
- nxp,tjr1443
- ti,tcan1042
- ti,tcan1043
- items:
- const: microchip,ata6561
- const: ti,tcan1042
'#phy-cells':
const: 0
Cheers,
Conor.
>
> '#phy-cells':
> const: 0
> --
> 2.34.1
>
>
Attachment:
signature.asc
Description: PGP signature
