Hello Stephen,
On Wed, 17 Jul 2024 16:33:34 -0700
Stephen Boyd <sboyd@xxxxxxxxxx> wrote:
> > @@ -1191,20 +1191,24 @@ static int si5351_dt_parse(struct i2c_client *client,
> > * property silabs,pll-source : <num src>, [<..>]
> > * allow to selectively set pll source
> > */
> > - of_property_for_each_u32(np, "silabs,pll-source", prop, p, num) {
> > + sz = of_property_read_variable_u32_array(np, "silabs,pll-source", array, 2, 4);
> > + sz = (sz == -EINVAL) ? 0 : sz; /* Missing property is OK */
> > + if (sz < 0)
> > + return dev_err_probe(&client->dev, sz, "invalid pll-source");
>
> Needs a newline on the printk message.
Ouch! Fix queued for v3.
Thanks,
Luca
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
