On Wed, Jul 17, 2024 at 10:27:35AM +0800, Inochi Amaoto wrote: > > And allow me clarify, what I said "a compatible that matches an actual SoC > > and use it everywhere" means to define "sophgo,cv1800-thermal" just as > > Haylen did and use it for all cv18xx SoC chips. > > > > I know it. But there may be something like the pinctrl. They share the same > logic, but have different data and layout. In fact, I am sure the thermal > is not suitable for this case. But for the thermal sensor, they are exactly the same, I don't think it's worth to add compatible strings for each SoC. Even though later SoCs do come with a different design, we could add a new one with little pain. Best regards, Haylen > > Anyway, as Conor suggested, we'd better not use wildcards (char 'x') in > > compatibles. > > > > Yeah, I agree. > > > Thanks, > > > > Chen > > > > > > Or we can add ones for each SoC and have a fallback to cv1800. > > > SoC specific compatible means most of the SoC have different part > > > for this peripheral. For safety, it may not use the fallback > > > generic compatible. > > > > > > Regards, > > > Inochi
