On Mon, Jul 15, 2024 at 3:57 AM Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote: > > Hi Krzysztof, > > Sorry for being late to the party, as v2 was sent, and applied ;-) > > On Fri, Jul 12, 2024 at 11:41 AM Krzysztof Kozlowski > <krzysztof.kozlowski@xxxxxxxxxx> wrote: > > On 11/07/2024 15:01, Rob Herring wrote: > > >> + - description: Incorrect compatibles used on other PowerPC devices > > >> + enum: > > >> + - 1682m-rng > > >> + - IBM,lhca > > >> + - IBM,lhea > > >> + - IBM,lhea-ethernet > > > > > >> + - mpc5200b-fec-phy > > >> + - mpc5200-serial > > >> + - mpc5200-sram > > > > > > Tell Grant he needs to document these. ;) JK > > > > > >> + - ohci-bigendian > > >> + - ohci-le > > >> + - ohci-littledian > > > > > > Given the typo, I think we can just drop this one from the driver. > > > > Sure, I'll send a patch. It could affect some ancient user, though... > > Although I really wonder if any of these PowerPC boxes are still alive. > > Looks like you forgot various "chrp,*" and "pnpPNP,*" ;-) There aren't any cases of 'pnpPNP' flagged by 'make dt_compatible_check'. Most of the cases in the kernel are with of_find_compatible_node() which doesn't get parsed. Maybe it could be. The intent wasn't really to be complete. Doesn't really matter until we get 'make dt_compatible_check' to zero. Still 1300 bindings to convert. Rob
