Hi Krzysztof, Sorry for being late to the party, as v2 was sent, and applied ;-) On Fri, Jul 12, 2024 at 11:41 AM Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> wrote: > On 11/07/2024 15:01, Rob Herring wrote: > >> + - description: Incorrect compatibles used on other PowerPC devices > >> + enum: > >> + - 1682m-rng > >> + - IBM,lhca > >> + - IBM,lhea > >> + - IBM,lhea-ethernet > > > >> + - mpc5200b-fec-phy > >> + - mpc5200-serial > >> + - mpc5200-sram > > > > Tell Grant he needs to document these. ;) JK > > > >> + - ohci-bigendian > >> + - ohci-le > >> + - ohci-littledian > > > > Given the typo, I think we can just drop this one from the driver. > > Sure, I'll send a patch. It could affect some ancient user, though... > Although I really wonder if any of these PowerPC boxes are still alive. Looks like you forgot various "chrp,*" and "pnpPNP,*" ;-) You can scavenge a few from my old LongTrail DTS http://g33rt.be/migrated/Linux/PPC/DeviceTree.html Note that my actual machine died 20 years ago... Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds