Hi Drew On Sat, Jul 13, 2024 at 03:35:09PM -0700, Drew Fustini wrote: > I am marking this as an RFC since it has been almost a year since the > previous series and Jisheng has handed it off to me. There was > discussion about the syscon for the APB registers in Jisheng's v2. I've > gone a different route and switched to adding a second memory region to > the gmac node: > > dwmac: DesignWare GMAC IP core registers > apb: GMAC APB registers > > This patch depends my clock controller series: > > [PATCH v3 0/7] clk: thead: Add support for TH1520 AP_SUBSYS clock controller > https://lore.kernel.org/linux-riscv/20240711-th1520-clk-v3-0-6ff17bb318fb@xxxxxxxxxxxxxxx/ > > and the pinctrl series from Emil: > > [PATCH v2 0/8] Add T-Head TH1520 SoC pin control > https://lore.kernel.org/linux-riscv/20240103132852.298964-1-emil.renner.berthing@xxxxxxxxxxxxx > > I have a branch with this series and the dependencies on top of 6.10-rc7: > https://github.com/pdp7/linux/tree/b4/thead-dwmac > > Changes since Jisheng v2: > - remove thead,gmacapb that references syscon for APB registers > - add a second memory region to gmac nodes for the APB registers > - Link: https://lore.kernel.org/all/20230827091710.1483-1-jszhang@xxxxxxxxxx/ I see the vast majority of the v2 comments left ignored: compatible-string, Tx/Rx common clock handle, clock delays, etc. Please take a closer look at v2 discussions and make sure the notes were implemented or send a reasonable response why it wasn't done. -Serge(y) > > Changes since Jisheng v1: > - rebase on the lastest net-next > - collect Reviewed-by tag > - address Krzysztof's comment of the dt binding > - fix "div is not initialised" issue pointed out by Simon > - Link: https://lore.kernel.org/all/20230820120213.2054-1-jszhang@xxxxxxxxxx/ > > --- > Emil Renner Berthing (1): > riscv: dts: thead: Add TH1520 ethernet nodes > > Jisheng Zhang (3): > dt-bindings: net: snps,dwmac: allow dwmac-3.70a to set pbl properties > dt-bindings: net: add T-HEAD dwmac support > net: stmmac: add glue layer for T-HEAD TH1520 SoC > > .../devicetree/bindings/net/snps,dwmac.yaml | 2 + > .../devicetree/bindings/net/thead,dwmac.yaml | 81 ++++++ > MAINTAINERS | 2 + > arch/riscv/boot/dts/thead/th1520-beaglev-ahead.dts | 89 ++++++ > .../boot/dts/thead/th1520-lichee-module-4a.dtsi | 131 +++++++++ > arch/riscv/boot/dts/thead/th1520.dtsi | 55 +++- > drivers/net/ethernet/stmicro/stmmac/Kconfig | 11 + > drivers/net/ethernet/stmicro/stmmac/Makefile | 1 + > drivers/net/ethernet/stmicro/stmmac/dwmac-thead.c | 300 +++++++++++++++++++++ > 9 files changed, 670 insertions(+), 2 deletions(-) > --- > base-commit: 568c4e4b646777f3373f383cc38864a3cd91bbb7 > change-id: 20240712-thead-dwmac-1d44c472bbd5 > > Best regards, > -- > Drew Fustini <dfustini@xxxxxxxxxxxxxxx> > >
