On Thu, 11 Jul 2024, at 9:52 PM, Andre Przywara wrote: > On Wed, 10 Jul 2024 18:17:17 -0500 > Chris Morgan <macroalpha82@xxxxxxxxx> wrote: > > Hi, > >> From: Chris Morgan <macromorgan@xxxxxxxxxxx> >> >> Change the Anbernic RG35XX series to use the r_i2c bus for the PMIC >> instead of the r_rsb bus. This is to keep the device tree consistent >> as there are at least 3 devices (the RG35XX-SP, RG28XX, and RG40XX-H) >> that have an external RTC on the r_i2c bus. > > The change itself looks alright, but I would like to see some Tested-by:s > from people with those Allwinner Anbernic devices, since the change affects > all of them. > >> Signed-off-by: Chris Morgan <macromorgan@xxxxxxxxxxx> > > Reviewed-by: Andre Przywara <andre.przywara@xxxxxxx> > Tested on RG35XX-H and RG35XX-Plus devices, confirmed AXP717 detected and configured using I2C bus by both kernel and u-boot. Also note this change corrects reboot behaviour on battery-based devices, where the AXP717 is not reset (and so remains in RSB mode) and is unable to be addressed by the u-boot SPL driver (which is I2C-only) on restart. Using I2C for all accesses prevents this behaviour. Tested-by: Ryan Walklin <ryan@xxxxxxxxxxxxx> Regards, Ryan
