Re: [PATCH V3 3/4] arm64: dts: allwinner: h616: Change RG35XX Series from r_rsb to r_i2c

[Andre Przywara <andre.przywara@xxxxxxx>]

On Wed, 10 Jul 2024 18:17:17 -0500
Chris Morgan <macroalpha82@xxxxxxxxx> wrote:

Hi,

> From: Chris Morgan <macromorgan@xxxxxxxxxxx>
> 
> Change the Anbernic RG35XX series to use the r_i2c bus for the PMIC
> instead of the r_rsb bus. This is to keep the device tree consistent
> as there are at least 3 devices (the RG35XX-SP, RG28XX, and RG40XX-H)
> that have an external RTC on the r_i2c bus.

The change itself looks alright, but I would like to see some Tested-by:s
from people with those Allwinner Anbernic devices, since the change affects
all of them.

> Signed-off-by: Chris Morgan <macromorgan@xxxxxxxxxxx>

Reviewed-by: Andre Przywara <andre.przywara@xxxxxxx>

Cheers,
Andre

> ---
>  .../boot/dts/allwinner/sun50i-h700-anbernic-rg35xx-2024.dts | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h700-anbernic-rg35xx-2024.dts b/arch/arm64/boot/dts/allwinner/sun50i-h700-anbernic-rg35xx-2024.dts
> index ee30584b6ad7..e2bbd22bd80a 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-h700-anbernic-rg35xx-2024.dts
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-h700-anbernic-rg35xx-2024.dts
> @@ -201,12 +201,12 @@ &pio {
>  	vcc-pi-supply = <&reg_cldo3>;
>  };
>  
> -&r_rsb {
> +&r_i2c {
>  	status = "okay";
>  
> -	axp717: pmic@3a3 {
> +	axp717: pmic@34 {
>  		compatible = "x-powers,axp717";
> -		reg = <0x3a3>;
> +		reg = <0x34>;
>  		interrupt-controller;
>  		#interrupt-cells = <1>;
>  		interrupt-parent = <&nmi_intc>;