On Thu, Jul 11, 2024 at 05:02:38PM GMT, Varadarajan Narayanan wrote:
> Use the icc-clk framework to enable few clocks to be able to
> create paths and use the peripherals connected on those NoCs.
>
> Signed-off-by: Varadarajan Narayanan <quic_varada@xxxxxxxxxxx>
> ---
> drivers/clk/qcom/gcc-ipq5332.c | 36 +++++++++++++++++++++++++++++-----
> 1 file changed, 31 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/clk/qcom/gcc-ipq5332.c b/drivers/clk/qcom/gcc-ipq5332.c
> index f98591148a97..6d7672cae0f7 100644
> --- a/drivers/clk/qcom/gcc-ipq5332.c
> +++ b/drivers/clk/qcom/gcc-ipq5332.c
> @@ -4,12 +4,14 @@
> */
>
> #include <linux/clk-provider.h>
> +#include <linux/interconnect-provider.h>
> #include <linux/mod_devicetable.h>
> #include <linux/module.h>
> #include <linux/platform_device.h>
> #include <linux/regmap.h>
>
> #include <dt-bindings/clock/qcom,ipq5332-gcc.h>
> +#include <dt-bindings/interconnect/qcom,ipq5332.h>
>
> #include "clk-alpha-pll.h"
> #include "clk-branch.h"
> @@ -131,12 +133,14 @@ static struct clk_alpha_pll gpll4_main = {
> * (will be added soon), so the clock framework
> * disables this source. But some of the clocks
> * initialized by boot loaders uses this source. So we
> - * need to keep this clock ON. Add the
> - * CLK_IGNORE_UNUSED flag so the clock will not be
> - * disabled. Once the consumer in kernel is added, we
> - * can get rid of this flag.
> + * need to keep this clock ON.
> + *
> + * After initial bootup, when the ICC framework turns
> + * off unused paths, as part of the icc-clk dependencies
> + * this clock gets disabled resulting in a hang. Marking
> + * it as critical to ensure it is not turned off.
Previous comment was pretty clear: there are missing consumers, the flag
will be removed once they are added. Current comment doesn't make sense.
What is the reason for the device hang if we have all the consumers in
place?
> */
> - .flags = CLK_IGNORE_UNUSED,
> + .flags = CLK_IS_CRITICAL,
> },
> },
> };
--
With best wishes
Dmitry
