… > Disabling source device resets the bit according to the source device's trace ID. How do you think about to improve such a change description with imperative wordings? https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.10-rc7#n94 … > +++ b/drivers/hwtracing/coresight/coresight-ccu.c > @@ -0,0 +1,290 @@ … > +static int __ccu_set_etr_traceid(struct coresight_device *csdev, > + uint32_t traceid, bool enable) > +{ … > + spin_lock_irqsave(&drvdata->spin_lock, flags); > + CS_UNLOCK(drvdata->base); … > + ccu_writel(drvdata, val, reg_offset); > + > + CS_LOCK(drvdata->base); > + spin_unlock_irqrestore(&drvdata->spin_lock, flags); > + return 0; > +} … Under which circumstances would you become interested to apply a statement like “guard(spinlock_irqsave)(&drvdata->spin_lock);”? https://elixir.bootlin.com/linux/v6.10-rc7/source/include/linux/spinlock.h#L574 Regards, Markus
