On Wed, Jul 03, 2024 at 07:11:10AM +0200, Krzysztof Kozlowski wrote: > On 02/07/2024 21:34, Chris Morgan wrote: > > From: Chris Morgan <macromorgan@xxxxxxxxxxx> > > > > Add the Anbernic RG35XXSP variant device and consolidate the Anbernic > > H700 devices. > > > > The Anbernic RG35XXSP is almost identical to the RG35XX-Plus, but in a > > clamshell form-factor with an external RTC and a lid switch. > > > > Signed-off-by: Chris Morgan <macromorgan@xxxxxxxxxxx> > > --- > > Documentation/devicetree/bindings/arm/sunxi.yaml | 9 +++++++-- > > 1 file changed, 7 insertions(+), 2 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/arm/sunxi.yaml b/Documentation/devicetree/bindings/arm/sunxi.yaml > > index c2a158b75e49..60b11b289535 100644 > > --- a/Documentation/devicetree/bindings/arm/sunxi.yaml > > +++ b/Documentation/devicetree/bindings/arm/sunxi.yaml > > @@ -61,14 +61,19 @@ properties: > > - const: anbernic,rg35xx-2024 > > - const: allwinner,sun50i-h700 > > > > + - description: Anbernic RG35XX H > > + items: > > + - const: anbernic,rg35xx-h > > + - const: allwinner,sun50i-h700 > > + > > - description: Anbernic RG35XX Plus > > items: > > - const: anbernic,rg35xx-plus > > - const: allwinner,sun50i-h700 > > > > - - description: Anbernic RG35XX H > > + - description: Anbernic RG35XX SP > > items: > > - - const: anbernic,rg35xx-h > > + - const: anbernic,rg35xx-sp > > Where is the consolidation? All this is supposed to be in an enum... > I didn't properly edit the notes when I posted the v2 sadly. I forgot to remove the text about consolidating the devices, since that's how the rest of the Allwinner devices are done today. I'll resubmit once I have a few more views on the other patches in this series. Thank you, Chris > > > Best regards, > Krzysztof >
