Re: [PATCH] watchdog: Add missing include for FIELD_*()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 7/1/24 00:56, Matti Vaittinen wrote:
The FIELD_PREP() and FIELD_GET() macros are defined in the
linux/bitfield.h. Include this header to avoid missing the macro
definitions.

Signed-off-by: Matti Vaittinen <mazziesaccount@xxxxxxxxx>
Reported-by: kernel test robot <lkp@xxxxxxxxx>
Closes: https://lore.kernel.org/oe-kbuild-all/202406300817.hcJ9VtLf-lkp@xxxxxxxxx/


Acked-by: Guenter Roeck <linux@xxxxxxxxxxxx>

---
This patch is built on the ib-mfd-regulator-watchdog-v6.11 tag.
These macros got included via some indirect route in my build
config on v6.10-rc1 - but the lkp reported problem on some config.

Please, let me know if this follow-up fix is Ok or if I should rather
respin the:
https://lore.kernel.org/all/20240627082555.GH2532839@xxxxxxxxxx/
with this fix. (I don't see much of potential bisecting problems if this
fix still gets in the next release, as the watchdog code is behind a new
Kconfig flag - but please let me know if I should re-spin whole series).
---
  drivers/watchdog/bd96801_wdt.c | 1 +
  1 file changed, 1 insertion(+)

diff --git a/drivers/watchdog/bd96801_wdt.c b/drivers/watchdog/bd96801_wdt.c
index ff51f42ced2a..12b74fd2bc05 100644
--- a/drivers/watchdog/bd96801_wdt.c
+++ b/drivers/watchdog/bd96801_wdt.c
@@ -5,6 +5,7 @@
   * ROHM BD96801 watchdog driver
   */
+#include <linux/bitfield.h>
  #include <linux/interrupt.h>
  #include <linux/kernel.h>
  #include <linux/mfd/rohm-bd96801.h>

base-commit: fcf1f960a6aa45a22efd4d49114c672ed305b85f





[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux