On Sat, Jun 29, 2024 at 04:34:25PM +0200, Andrew Lunn wrote: > It has been a long time since i reviewed a kirkwood DT > description. Also, best practices have changed, so the example you > copied is probably doing things which today would be classed as wrong. > > > +// SPDX-License-Identifier: GPL-2.0-or-later > > It is typical to use a dual license now: > > // SPDX-License-Identifier: (GPL-2.0+ OR MIT) Yes, but more importantly, they should be consistent... GPL-2.0+ in favor of GPL-2.0-or-later > > However, if this is mostly Sunke Schluters work, you probably cannot > change the license without his agreement. > > > +/* > > + * Device Tree file for D-Link DNS-320L > > + * > > + * Copyright (C) 2024, Zoltan HERPAI <wigyori@xxxxxxx> > > + * Copyright (C) 2015, Sunke Schluters <sunke-dev@xxxxxxxxxxxxx> > > + * > > + * This file is based on the works of: > > + * - Sunke Schluters <sunke-dev@xxxxxxxxxxxxx> > > + * - https://github.com/scus1/dns320l/blob/master/kernel/dts/kirkwood-dns320l.dts > > + * - Andreas Bohler <dev@xxxxxxxxxxx>: > > + * - http://www.aboehler.at/doku/doku.php/projects:dns320l > > + * - http://www.aboehler.at/hg/linux-dns320l/file/ba7a60ad7687/linux-3.12/kirkwood-dns320l.dts > > + */ > > + > > +/dts-v1/; > > + > > +#include "kirkwood.dtsi" > > +#include "kirkwood-6281.dtsi" And these are GPL-2.0-only, so this one should match. Rob
