It has been a long time since i reviewed a kirkwood DT description. Also, best practices have changed, so the example you copied is probably doing things which today would be classed as wrong. > +// SPDX-License-Identifier: GPL-2.0-or-later It is typical to use a dual license now: // SPDX-License-Identifier: (GPL-2.0+ OR MIT) However, if this is mostly Sunke Schluters work, you probably cannot change the license without his agreement. > +/* > + * Device Tree file for D-Link DNS-320L > + * > + * Copyright (C) 2024, Zoltan HERPAI <wigyori@xxxxxxx> > + * Copyright (C) 2015, Sunke Schluters <sunke-dev@xxxxxxxxxxxxx> > + * > + * This file is based on the works of: > + * - Sunke Schluters <sunke-dev@xxxxxxxxxxxxx> > + * - https://github.com/scus1/dns320l/blob/master/kernel/dts/kirkwood-dns320l.dts > + * - Andreas Bohler <dev@xxxxxxxxxxx>: > + * - http://www.aboehler.at/doku/doku.php/projects:dns320l > + * - http://www.aboehler.at/hg/linux-dns320l/file/ba7a60ad7687/linux-3.12/kirkwood-dns320l.dts > + */ > + > +/dts-v1/; > + > +#include "kirkwood.dtsi" > +#include "kirkwood-6281.dtsi" > + > +/ { > + model = "D-Link DNS-320L"; > + compatible = "dlink,dns320l", "marvell,kirkwood-88f6702", "marvell,kirkwood"; > + > + memory { > + device_type = "memory"; > + reg = <0x00000000 0x10000000>; > + }; > + > + chosen { > + bootargs = "console=ttyS0,115200n8 earlyprintk"; > + stdout-path = &uart0; I _think_ current best practice is to make the serial port speed part of the stdout-path stdout-path = &uart0:115200n8; Also, earlyprintk is a debug flag, it should not be needed for a production DT file. > + }; > + > + gpio-keys { > + compatible = "gpio-keys"; > + #address-cells = <1>; > + #size-cells = <0>; > + pinctrl-0 = <&pmx_buttons>; > + pinctrl-names = "default"; > + > + button@1 { > + label = "Reset push button"; > + linux,code = <KEY_RESTART>; > + gpios = <&gpio0 28 1>; Please use GPIO_ACTIVE_LOW rather than 1. Also for other places gpios are used. Thanks Andrew
